Open
Conversation
Contributor
|
Hello Louis! Thank you for your PR! I have a quick question, does this PR implement just keywords (IMAP standard) or labels similar Best regards |
Contributor
Author
|
Just keywords, but that's enough to quite easily implement labels in your webmail. I've implemented labels in our webmail using this :) Since labels aren't an IMAP server feature, I didn't feel like it was in scope for wildduck, but keywords are. |
Contributor
Author
|
Ah something I forgot to say is that I of course added a keyword filter to the message search endpoint. So you can actually list messages for a keyword. That together with counters makes it usable as labels within a webmail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been a long time coming, finally found the motivation recently :)
This PR adds support for custom keywords (which are just flags). You can use these to represent labels in a webmail (#763), and sync those same labels with for example Thunderbird over IMAP.
Overview:
KEYWORD_COUNTERS) for that keyword. Implemented it this way to avoid computing counters for irrelevant keywords IMAP clients might addkeywordsonEXISTS, andaddedKeywordsandremovedKeywordsonFETCHFLAGGED_COUNTER)Some things:
$addToSetand$pullin the same query. I switched it over to a simple aggregation pipeline that does allow for this.flaggedin the db for some reason? Assuming that's wrong and fixedI normally only work on modern TS codebases, so JS plus the old callback style isn't too familiar for me. Let me know if you see any obvious mistakes :)